fix: handle empty responses in HttpHandler#5
Closed
RickieeeDev wants to merge 4 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SDK’s HttpHandler response parsing to avoid throwing when the server returns an empty body (common for 204/205 responses), improving resilience for endpoints that legitimately return no content.
Changes:
- Added explicit handling for empty HTTP responses (204/205,
content-length: 0, empty/whitespace body). - Switched JSON parsing flow to read the response body as text first, then parse only when non-empty.
- Centralized “empty response” behavior via a helper method.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IamKirbki
requested changes
Apr 10, 2026
IamKirbki
left a comment
IamKirbki
left a comment
Contributor
There was a problem hiding this comment.
Why so many different checks
Contributor
|
Superseded by #8. The old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.